Celtx import - Existing Breakdown fields of different custom types

Announcements, support questions, and discussion for the Dialogue System.
cbrito
Posts: 25
Joined: Wed Oct 26, 2022 11:45 am

Celtx import - Existing Breakdown fields of different custom types

Post by cbrito »

Hey Tony,

We've found a bug, or unexpected behavior in the celtx import related to shared breakdown fields with different custom types. Here's the steps to reproduce
  • Create two different Custom Types
    Add a first breakdown of the first custom type
    Add a second breakdown field of the second custom type, but select the last added field in the existing dropdown
    Export project and import it to the Dialogue System
    Both dialogue nodes will have the two breakdown fields with the same custom type as key.
I've added some screenshots and a JSON that reproduces the bug.
Attachments
Script Bug - Existing Breakdown Field With Different Custom Type.zip
(2.45 KiB) Downloaded 77 times
NodeFields2.PNG
NodeFields2.PNG (49.65 KiB) Viewed 1567 times
NodeFields1.PNG
NodeFields1.PNG (49.66 KiB) Viewed 1567 times
DocumentView.PNG
DocumentView.PNG (48.05 KiB) Viewed 1567 times
BreakdownView2.PNG
BreakdownView2.PNG (22.59 KiB) Viewed 1567 times
BreakdownView1.PNG
BreakdownView1.PNG (22.74 KiB) Viewed 1567 times
User avatar
Tony Li
Posts: 22131
Joined: Thu Jul 18, 2013 1:27 pm

Re: Celtx import - Existing Breakdown fields of different custom types

Post by Tony Li »

Thank you for the detailed explanation and data. I'll try to have a fix for you by tomorrow. It will also include the earlier change you requested that sets the Celtx ID field of sequence nodes to the node's ID instead of the parent sequence's ID.
User avatar
Tony Li
Posts: 22131
Joined: Thu Jul 18, 2013 1:27 pm

Re: Celtx import - Existing Breakdown fields of different custom types

Post by Tony Li »

Hi! I believe this patch should fix the issue:

DS_GemPatch_2023-04-26.unitypackage
cbrito
Posts: 25
Joined: Wed Oct 26, 2022 11:45 am

Re: Celtx import - Existing Breakdown fields of different custom types

Post by cbrito »

Hi Tony!

The patch fixed the Field key issue, but unfortunately the first node Field valeu is wrong. The second is correct.
Attachments
NodeFields2_26-04.PNG
NodeFields2_26-04.PNG (48.54 KiB) Viewed 1551 times
NodeFields1_26-04.PNG
NodeFields1_26-04.PNG (49.02 KiB) Viewed 1551 times
cbrito
Posts: 25
Joined: Wed Oct 26, 2022 11:45 am

Re: Celtx import - Existing Breakdown fields of different custom types

Post by cbrito »

Hi again!

We updated Dialogue System for version 2.2.35 (we were on 2.2.33) to test the patch and apparently the importer is not importing conditions anymore. Is this issue known?

I've added a JSON with an example.
Attachments
Script Bug - Existing Breakdown Field With Different Custom Type.zip
(3.52 KiB) Downloaded 76 times
User avatar
Tony Li
Posts: 22131
Joined: Thu Jul 18, 2013 1:27 pm

Re: Celtx import - Existing Breakdown fields of different custom types

Post by Tony Li »

Hi,

I'll look into this today and get back to you as soon as I can.
User avatar
Tony Li
Posts: 22131
Joined: Thu Jul 18, 2013 1:27 pm

Re: Celtx import - Existing Breakdown fields of different custom types

Post by Tony Li »

Hi,

This patch should resolve both issues:

DS_GemPatch_2023-05-02.unitypackage
cbrito
Posts: 25
Joined: Wed Oct 26, 2022 11:45 am

Re: Celtx import - Existing Breakdown fields of different custom types

Post by cbrito »

Hi Tony!

We tested the lastest Dialogue System version with the patch and we have the celtx dialogue id in each node and conditions are fixed.

Although the breakdown field issue in the example, we replicated the issue in a different situation.

We were able to fix the issue ourselves. See if the following patch makes sense to you.
Attachments
DS_Chimera_GemPatch_2023-05-04.zip
(10.08 KiB) Downloaded 29 times
User avatar
Tony Li
Posts: 22131
Joined: Thu Jul 18, 2013 1:27 pm

Re: Celtx import - Existing Breakdown fields of different custom types

Post by Tony Li »

Hi,

That doesn't appear to work correctly. When importing your "Script Bug - Existing Breakdown Field With Different Custom Type.json" file, it imports the values like this:

gemCustomType.png
gemCustomType.png (22.63 KiB) Viewed 1413 times
cbrito
Posts: 25
Joined: Wed Oct 26, 2022 11:45 am

Re: Celtx import - Existing Breakdown fields of different custom types

Post by cbrito »

Hi!

That's what we intended given the Celtx project I showed you in the first message :)
Post Reply