Bark Performance even when cached is ticked

[joshualoveridge]

Bark Performance even when cached is ticked is really poor when it is triggered,what would be the solution for this?

is their a way to make them all cache at the start?

[Tony Li]

Hi,

It really should do that, shouldn't it. BarkOnIdle caches at the start, but DialogueSystemTrigger doesn't. This patch makes DialogueSystemTrigger cache on start, too:

DS227_DialogueSystemTriggerPatch_2020-06-08.unitypackage

[joshualoveridge]

Hey

I tried using the package but it gave loads of errors, here is the code im using, doesn't anything pop out as really bad?
Im literally 2 weeks out from launch so a rag tag solution is fine

Code: Select all

using UnityEngine;
using DarkTonic.MasterAudio;

namespace PixelCrushers.DialogueSystem.OpsiveUCCSupport
{

    /// <summary>
    /// This is a Dialogue System Trigger that serves as a UCC Interactable target.
    /// </summary>
    public class DialogueSystemTriggerInteractableTarget : DialogueSystemTrigger, Opsive.UltimateCharacterController.Traits.IInteractableTarget
    {
        private Transform m_player = null;
        private Transform player
        {
            get
            {
                if (m_player == null)
                {
                    var go = GameObject.FindGameObjectWithTag("Player");
                    if (go != null) m_player = go.transform;
                }
                return m_player;
            }
        }

        public bool CanInteract()
        {
            return true;
        }

        public void Interact()
        {
            if(!GameManager.instance.battling){
            if (player != null)
            {
                OnUse(player.transform);
                MasterAudio.PlaySound("PopTalk");
            }
            else
            {
                OnUse();
                MasterAudio.PlaySound("PopTalk");

            }

            }
        }

    }
}

Code: Select all

// Copyright (c) Pixel Crushers. All rights reserved.
using UnityEngine;
using System;
using System.Collections;
namespace PixelCrushers.DialogueSystem
{
    /// <summary>
    /// The Dialogue System Trigger is a general-purpose trigger that can execute most
    /// Dialogue System functions such as starting conversations, barks, alerts, 
    /// sequences, and Lua code.
    /// </summary>
    [AddComponentMenu("")] // Deprecated.
    public class DialogueSystemTrigger : MonoBehaviour
    {
        #region Serialized Variables
        /// <summary>
        /// The trigger that this component listens for.
        /// </summary>
        [Tooltip("The trigger that this component listens for.")]
        [DialogueSystemTriggerEvent]
        public DialogueSystemTriggerEvent trigger = DialogueSystemTriggerEvent.OnUse;
        /// <summary>
        /// The conditions under which the trigger will fire.
        /// </summary>
        public Condition condition;
        // //////////////////////////////////////////////////////////////////////////////////
        // Quest:
        /// <summary>
        /// If `true`, set the quest state.
        /// </summary>
        [Tooltip("Set a quest state when triggered.")]
        public bool setQuestState = true;
        /// <summary>
        /// The name of the quest.
        /// </summary>
        [QuestPopup]
        public string questName;
        /// <summary>
        /// The new state of the quest when triggered.
        /// </summary>
        [Tooltip("Set quest's main state.")]
        [QuestState]
        public QuestState questState;
        /// <summary>
        /// If `true`, set the quest entry state.
        /// </summary>
        [Tooltip("Set state of a quest entry.")]
        public bool setQuestEntryState = false;
        /// <summary>
        /// The quest entry number whose state to change.
        /// </summary>
        public int questEntryNumber = 1;
        /// <summary>
        /// The new state of the quest entry when triggered.
        /// </summary>
        [QuestState]
        public QuestState questEntryState;
        // //////////////////////////////////////////////////////////////////////////////////
        // Lua:
        /// <summary>
        /// The lua code to run.
        /// </summary>
        [Tooltip("Lua code to run. Leave blank for no message.")]
        public string luaCode = string.Empty;
        // //////////////////////////////////////////////////////////////////////////////////
        // Sequence:
        [TextArea(1, 10)]
        public string sequence = string.Empty;
        /// <summary>
        /// The speaker to use for the sequence (or null if no speaker is needed). Sequence
        /// commands can reference 'speaker' and 'listener', so you may need to define them
        /// in this component.
        /// </summary>
        [Tooltip("Optional GameObject to use if sequence uses 'speaker' keyword.")]
        public Transform sequenceSpeaker;
        /// <summary>
        /// The listener to use for the sequence (or null if no listener is needed). Sequence
        /// commands can reference 'speaker' and 'listener', so you may need to define them
        /// in this component.
        /// </summary>
        [Tooltip("Optional GameObject to use if sequence uses 'listener' keyword.")]
        public Transform sequenceListener;
        public bool waitOneFrameOnStartOrEnable = true;
        // //////////////////////////////////////////////////////////////////////////////////
        // Alert:
        /// <summary>
        /// An optional gameplay alert message. Leave blank for no message.
        /// </summary>
        [Tooltip("Alert message. Leave blank for no message.")]
        public string alertMessage;
        /// <summary>
        /// An optional localized text table to use for the alert message.
        /// </summary>
        [Tooltip("Optional text table to use to localize messages.")]
        public TextTable textTable;
        public float alertDuration = 0;
        // //////////////////////////////////////////////////////////////////////////////////
        // Send Message:
        [Serializable]
        public class SendMessageAction
        {
            [Tooltip("Target GameObject.")]
            public GameObject gameObject = null;
            [Tooltip("Name of method to call on target. One or more scripts on target should have a method with this name.")]
            public string message = "OnUse";
            [Tooltip("Optional method parameter. Specify if method accepts a string parameter.")]
            public string parameter = string.Empty;
        }
        /// <summary>
        /// Targets and messages to send when the trigger fires.
        /// </summary>
        public SendMessageAction[] sendMessages = new SendMessageAction[0];
        // //////////////////////////////////////////////////////////////////////////////////
        // Bark:
        public enum BarkSource { None, Conversation, Text }
        [Tooltip("Where to get content to bark.")]
        public BarkSource barkSource = BarkSource.None;
        /// <summary>
        /// The title of the bark conversation. Used if barkSource is set to conversation.
        /// </summary>
        [Tooltip("Conversation to get bark content from.")]
        [ConversationPopup(false)]
        public string barkConversation = string.Empty;
        /// <summary>
        /// Text to bark. Used if barkSource is text. Will be localized through Dialogue Manager's Text Table if assigned.
        /// </summary>
        [Tooltip("Bark this text. Will be localized through Dialogue Manager's Text Table if assigned.")]
        public string barkText = string.Empty;
        /// <summary>
        /// Optional sequence to play when barking text.
        /// </summary>
        [Tooltip("Optional sequence to play when barking text.")]
        public string barkTextSequence = string.Empty;
        /// <summary>
        /// The barker.
        /// </summary>
        [Tooltip("Character that bark comes from. Should have a bark UI or a Dialogue Actor component with a bark UI prefab assigned.")]
        public Transform barker;
        /// <summary>
        /// The target of the bark.
        /// </summary>
        [Tooltip("Optional target of the bark. Receives OnBark events.")]
        public Transform barkTarget;
        /// <summary>
        /// Specifies the order to run through the list of barks.
        /// 
        /// - Random: Choose a random bark from the conversation.
        /// - Sequential: Choose the barks in order from first to last, looping at the end.
        /// </summary>
        public BarkOrder barkOrder = BarkOrder.Random;
        /// <summary>
        /// Are barks allowed during conversations?
        /// </summary>
        public bool allowBarksDuringConversations = false;
        /// <summary>
        /// Skip bark if no valid entries.
        /// </summary>
        [Tooltip("Only trigger if at least one entry's Conditions are currently true.")]
        public bool skipBarkIfNoValidEntries;
        /// <summary>
        /// If ticked, bark info is cached during the first bark. This can reduce stutter
        /// when barking on slower mobile devices, but barks are not reevaluated each time
        /// as the state changes, barks use no em formatting codes, and sequences are not
        /// played with barks.
        /// </summary>
        [Tooltip("Cache all lines during first bark. This can reduce stutter when barking on slower mobile devices, but barks' conditions are not reevaluated each time as the state changes, barks use no em formatting codes, and sequences are not played with barks.")]
         public bool cacheBarkLines = true;
        // //////////////////////////////////////////////////////////////////////////////////
        // Conversation:
        /// <summary>
        /// The title of the conversation to start.
        /// </summary>
        [Tooltip("Conversation to start. Leave blank for no conversation.")]
        [ConversationPopup(false)]
        public string conversation = string.Empty;
        /// <summary>
        /// The conversant of the conversation. If not set, this game object. The actor is usually
        /// the entity that caused the trigger (for example, the player that hits the "Use" button
        /// on the conversant, thereby triggering OnUse).
        /// </summary>
        [Tooltip("Other actor (e.g., NPC). If unassigned, this GameObject.")]
        public Transform conversationConversant;
        /// <summary>
        /// The actor to converse with. If not set, the game object that triggered the event.
        /// </summary>
        [Tooltip("Primary actor (e.g., player). If unassigned, GameObject that triggered conversation.")]
        public Transform conversationActor;
        /// <summary>
        /// Only start if no other conversation is active.
        /// </summary>
        [Tooltip("Only trigger if no other conversation is already active.")]
        public bool exclusive = false;
        /// <summary>
        /// If this is <c>true</c> and no valid entries currently link from the start entry,
        /// don't start the conversation.
        /// </summary>
        [Tooltip("Only trigger if at least one entry's Conditions are currently true.")]
        public bool skipIfNoValidEntries = true;
        /// <summary>
        /// Set <c>true</c> to stop the conversation if the actor leaves the trigger area.
        /// </summary>
        [Tooltip("Stop conversation if actor leaves trigger area.")]
        public bool stopConversationOnTriggerExit = false;
        [Tooltip("Stop conversation if player exceeds Max Conversation Distance.")]
        public bool stopConversationIfTooFar = false;
        [Tooltip("If Stop Conversation If Too Far is ticked, this is too far.")]
        public float maxConversationDistance = 5f;
        [Tooltip("Check distance on this frequency.")]
        public float monitorConversationDistanceFrequency = 1f;
        [Tooltip("Make the cursor visible when the conversation starts. Return to previous visibility state when conversation ends.")]
        public bool showCursorDuringConversation = false;
        [Tooltip("Set Time.timeScale to 0 during conversation, back to previous timeScale when conversation ends.")]
        public bool pauseGameDuringConversation = false;
        // //////////////////////////////////////////////////////////////////////////////////
        // Set Active:
        [Serializable]
        public class SetGameObjectActiveAction
        {
            public Condition condition = new Condition();
            public Transform target;
            public Toggle state;
        }
        public SetGameObjectActiveAction[] setActiveActions = new SetGameObjectActiveAction[0];
        // //////////////////////////////////////////////////////////////////////////////////
        // Set Enabled:
        [Serializable]
        public class SetComponentEnabledAction
        {
            public Condition condition = new Condition();
            public Component target;
            public Toggle state;
        }
        public SetComponentEnabledAction[] setEnabledActions = new SetComponentEnabledAction[0];
        // //////////////////////////////////////////////////////////////////////////////////
        // Set Animator State:
        [Serializable]
        public class SetAnimatorStateAction
        {
            public Condition condition = new Condition();
            [Tooltip("Set the state of the animator on this GameObject. Animator can be on a child GameObject.")]
            public Transform target;
            [Tooltip("State to crossfade to.")]
            public string stateName;
            public float crossFadeDuration = 0.3f;
        }
        public SetAnimatorStateAction[] setAnimatorStateActions = new SetAnimatorStateAction[0];
        // //////////////////////////////////////////////////////////////////////////////////
        // UnityEvent:
        public GameObjectUnityEvent onExecute = new GameObjectUnityEvent();
        // //////////////////////////////////////////////////////////////////////////////////
        [HideInInspector]
        public bool useConversationTitlePicker = true;
        [HideInInspector]
        public bool useBarkTitlePicker = true;
        [HideInInspector]
        public bool useQuestNamePicker = true;
        [HideInInspector]
        public DialogueDatabase selectedDatabase = null;
        #endregion
        #region Properties
        /// <summary>
        /// Gets the sequencer used by the current bark, if a bark is playing.
        /// If a bark is not playing, this is undefined. To check if a bark is
        /// playing, check the bark UI's IsPlaying property.
        /// </summary>
        /// <value>The sequencer.</value>
        public Sequencer sequencer { get; protected set; }
        #endregion
        #region Private/Protected Variables
        protected BarkHistory barkHistory;
        protected ConversationState cachedState = null;
        protected IBarkUI barkUI = null;
        protected float earliestTimeToAllowTriggerExit = 0;
        protected const float MarginToAllowTriggerExit = 0.2f;
        protected Coroutine monitorDistanceCoroutine = null;
        protected bool wasCursorVisible;
        protected CursorLockMode savedLockState;
        protected float preConversationTimeScale = 1;
        protected bool tryingToStart = false;
        #endregion
        #region Trigger Checks
        public virtual void Awake()
        {
            barkHistory = new BarkHistory(barkOrder);
            sequencer = null;
            cacheBarkLines = true;
        }
        public virtual void Start()
        {
            if (trigger == DialogueSystemTriggerEvent.OnCollisionEnter ||
                trigger == DialogueSystemTriggerEvent.OnCollisionExit ||
                trigger == DialogueSystemTriggerEvent.OnTriggerEnter ||
                trigger == DialogueSystemTriggerEvent.OnTriggerExit)
            {
                bool found = false;
                if (GetComponent<Collider>() != null) found = true;
#if USE_PHYSICS2D || !UNITY_2018_1_OR_NEWER
                if (!found && GetComponent<Collider2D>() != null) found = true;
#endif
                if (!found && DialogueDebug.logWarnings) Debug.LogWarning("Dialogue System: Dialogue System Trigger is set to a mode that requires a collider, but it has no collider component.", this);
            }
            else if (trigger == DialogueSystemTriggerEvent.OnStart)
            {
                // Wait until end of frame to allow all other components to finish their Start() methods:
                StartCoroutine(StartAtEndOfFrame());
            }
           // if (cachedState == null) PopulateCache(conversationConversant, conversationActor);
         //  StartCoroutine(waited());
        }
        IEnumerator waited(){
            yield return new WaitForSeconds(3f);
            if (cachedState == null) PopulateCache(conversationActor, conversationConversant);
            
        }
        public void OnBarkStart(Transform actor)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnBarkStart)) TryStart(actor);
        }
        public void OnBarkEnd(Transform actor)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnBarkEnd)) TryStart(actor);
        }
        public void OnConversationStart(Transform actor)
        {
            if (!enabled) return;
            if (trigger == DialogueSystemTriggerEvent.OnConversationStart) TryStart(actor);
            if (showCursorDuringConversation)
            {
                wasCursorVisible = Cursor.visible;
                savedLockState = Cursor.lockState;
                StartCoroutine(ShowCursorAfterOneFrame());
            }
            if (pauseGameDuringConversation)
            {
                preConversationTimeScale = Time.timeScale;
                Time.timeScale = 0;
            }
        }
        protected IEnumerator ShowCursorAfterOneFrame()
        {
            yield return null;
            Cursor.visible = true;
            Cursor.lockState = CursorLockMode.None;
        }
        public void OnConversationEnd(Transform actor)
        {
            if (!enabled) return;
            if (trigger == DialogueSystemTriggerEvent.OnConversationEnd) TryStart(actor);
            StopMonitoringConversationDistance();
            if (showCursorDuringConversation)
            {
                Cursor.visible = wasCursorVisible;
                Cursor.lockState = savedLockState;
            }
            if (pauseGameDuringConversation)
            {
                Time.timeScale = preConversationTimeScale;
            }
        }
        public void OnSequenceStart(Transform actor)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnSequenceStart)) TryStart(actor);
        }
        public void OnSequenceEnd(Transform actor)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnSequenceEnd)) TryStart(actor);
        }
        public void OnSequenceEnd()
        {
            OnSequenceEnd(null);
        }
        public void OnUse(Transform actor)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnUse)) TryStart(actor);
        }
        public void OnUse(string message)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnUse)) TryStart(null);
        }
        public void OnUse()
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnUse)) TryStart(null);
        }
        public void OnTriggerEnter(Collider other)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnTriggerEnter)) TryStart(other.transform);
        }
        public void OnTriggerExit(Collider other)
        {
            CheckOnTriggerExit(other.transform);
        }
#if USE_PHYSICS2D || !UNITY_2018_1_OR_NEWER
        public void OnTriggerEnter2D(Collider2D other)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnTriggerEnter)) TryStart(other.transform);
        }
        public void OnTriggerExit2D(Collider2D other)
        {
            CheckOnTriggerExit(other.transform);
        }
        public void OnCollisionEnter2D(Collision2D collision)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnTriggerEnter)) TryStart(collision.collider.transform);
        }
        public void OnCollisionExit2D(Collision2D collision)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnTriggerExit)) TryStart(collision.collider.transform);
        }
#endif
        protected void CheckOnTriggerExit(Transform otherTransform)
        {
            if (!enabled) return;
            if (stopConversationOnTriggerExit &&
                DialogueManager.isConversationActive &&
                (Time.time > earliestTimeToAllowTriggerExit) &&
                ((DialogueManager.currentActor == otherTransform) || (DialogueManager.currentConversant == otherTransform)))
            {
                if (DialogueDebug.logInfo) Debug.Log("Dialogue System: Stopping conversation because " + otherTransform + " exited trigger area.", this);
                DialogueManager.StopConversation();
            }
            else if (trigger == DialogueSystemTriggerEvent.OnTriggerExit)
            {
                TryStart(otherTransform.transform);
            }
        }
        public void OnCollisionEnter(Collision collision)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnCollisionEnter)) TryStart(collision.collider.transform);
        }
        public void OnCollisionExit(Collision collision)
        {
            if (enabled && (trigger == DialogueSystemTriggerEvent.OnTriggerExit)) TryStart(collision.collider.transform);
        }
        protected bool listenForOnDestroy = false;
        public void OnEnable()
        {
            PersistentDataManager.RegisterPersistentData(gameObject);
            listenForOnDestroy = true;
            // Waits one frame to allow all other components to finish their OnEnable() methods.
            if (trigger == DialogueSystemTriggerEvent.OnEnable) StartCoroutine(StartAtEndOfFrame());
        }
        public void OnDisable()
        {
            StopMonitoringConversationDistance();
            StopAllCoroutines();
            PersistentDataManager.UnregisterPersistentData(gameObject);
            if (listenForOnDestroy && trigger == DialogueSystemTriggerEvent.OnDisable) TryStart(null);
        }
        public void OnLevelWillBeUnloaded()
        {
            listenForOnDestroy = false;
        }
        public void OnApplicationQuit()
        {
            listenForOnDestroy = false;
        }
        public void OnDestroy()
        {
            if (listenForOnDestroy && trigger == DialogueSystemTriggerEvent.OnDestroy) TryStart(null);
        }
        #endregion
        #region Execution
        protected IEnumerator StartAtEndOfFrame()
        {
            yield return new WaitForEndOfFrame();
            TryStart(null);
        }
        public void TryStart(Transform actor)
        {
            TryStart(actor, actor);
        }
        /// <summary>
        /// Sets the quest status if the condition is true.
        /// </summary>
        public void TryStart(Transform actor, Transform interactor)
        {
            if (tryingToStart) return;
            tryingToStart = true;
            try
            {
                if (((condition == null) || condition.IsTrue(interactor)))
                {
                    Fire(actor);
                }
            }
            finally
            {
                tryingToStart = false;
            }
        }
        public void Fire(Transform actor)
        {
            if (DialogueDebug.logInfo) Debug.Log("Dialogue System: Dialogue System Trigger is firing " + trigger + ".", this);
            DoQuestAction();
            DoLuaAction();
            DoSequenceAction(actor);
            DoAlertAction();
            DoSendMessageActions();
            DoBarkAction(actor);
            DoConversationAction(actor);
            DoSetActiveActions(actor);
            DoSetEnabledActions(actor);
            DoSetAnimatorStateActions(actor);
            onExecute.Invoke((actor != null) ? actor.gameObject : null);
            DialogueManager.SendUpdateTracker();
        }
        #endregion
        #region Quest Action
        protected virtual void DoQuestAction()
        {
            if (string.IsNullOrEmpty(questName)) return;
            if (setQuestState) QuestLog.SetQuestState(questName, questState);
            if (setQuestEntryState) QuestLog.SetQuestEntryState(questName, questEntryNumber, questEntryState);
        }
        #endregion
        #region Lua Action
        protected virtual void DoLuaAction()
        {
            if (string.IsNullOrEmpty(luaCode)) return;
            Lua.Run(luaCode, DialogueDebug.logInfo);
        }
        #endregion
        #region Sequence Action
        protected virtual void DoSequenceAction(Transform actor)
        {
            if (string.IsNullOrEmpty(sequence)) return;
            DialogueManager.PlaySequence(sequence, Tools.Select(sequenceSpeaker, transform), Tools.Select(sequenceListener, actor));
        }
        #endregion
        #region Alert Action
        protected virtual void DoAlertAction()
        {
            if (string.IsNullOrEmpty(alertMessage)) return;
            string localizedAlertMessage;
            if ((textTable != null) && textTable.HasFieldTextForLanguage(alertMessage, Localization.GetCurrentLanguageID(textTable)))
            {
                localizedAlertMessage = textTable.GetFieldTextForLanguage(alertMessage, Localization.GetCurrentLanguageID(textTable));
            }
            else
            {
                localizedAlertMessage = DialogueManager.GetLocalizedText(alertMessage);
            }
            if (Mathf.Approximately(0, alertDuration))
            {
                DialogueManager.ShowAlert(localizedAlertMessage);
            }
            else
            {
                DialogueManager.ShowAlert(localizedAlertMessage, alertDuration);
            }
        }
        #endregion
        #region SendMessage Action
        protected virtual void DoSendMessageActions()
        {
            for (int i = 0; i < sendMessages.Length; i++)
            {
                var sma = sendMessages[i];
                if (sma != null && sma.gameObject != null && !string.IsNullOrEmpty(sma.message))
                {
                    sma.gameObject.SendMessage(sma.message, sma.parameter, SendMessageOptions.DontRequireReceiver);
                }
            }
        }
        #endregion
        #region Bark Action
        protected virtual void DoBarkAction(Transform actor)
        {
            switch (barkSource)
            {
                case BarkSource.Conversation:
                    if (string.IsNullOrEmpty(barkConversation)) return;
                    if (DialogueManager.isConversationActive && !allowBarksDuringConversations)
                    {
                        if (DialogueDebug.logWarnings) Debug.LogWarning("Dialogue System: Bark triggered on " + name + ", but a conversation is already active.", GetBarker(barkConversation));
                    }
                    else if (cacheBarkLines)
                    {
                        BarkCachedLine(GetBarker(barkConversation), Tools.Select(barkTarget, actor));
                    }
                    else
                    {
                        DialogueManager.Bark(barkConversation, GetBarker(barkConversation), Tools.Select(barkTarget, actor), barkHistory);
                        sequencer = BarkController.LastSequencer;
                    }
                    break;
                case BarkSource.Text:
                    if (string.IsNullOrEmpty(barkText)) return;
                    if (DialogueManager.isConversationActive && !allowBarksDuringConversations)
                    {
                        if (DialogueDebug.logWarnings) Debug.LogWarning("Dialogue System: Bark triggered on " + name + ", but a conversation is already active.", GetBarker(null));
                    }
                    else
                    {
                        DialogueManager.BarkString(barkText, GetBarker(null), Tools.Select(barkTarget, actor), barkTextSequence);
                        sequencer = BarkController.LastSequencer;
                    }
                    break;
            }
        }
        protected virtual Transform GetBarker(string conversation)
        {
            if (barker != null) return barker;
            if (!string.IsNullOrEmpty(conversation))
            {
                var conversationAsset = DialogueManager.MasterDatabase.GetConversation(conversation);
                if (conversationAsset != null)
                {
                    var barkActor = DialogueManager.MasterDatabase.GetActor(conversationAsset.ConversantID);
                    var registeredTransform = (barkActor != null) ? CharacterInfo.GetRegisteredActorTransform(barkActor.Name) : null;
                    if (registeredTransform != null) return registeredTransform;
                }
            }
            return this.transform;
        }
        protected virtual string GetBarkerName()
        {
            return DialogueActor.GetActorName(GetBarker((barkSource == BarkSource.Conversation) ? barkConversation : null));
        }
        protected virtual void BarkCachedLine(Transform speaker, Transform listener)
        {
            if (barkUI == null) barkUI = speaker.GetComponentInChildren(typeof(IBarkUI)) as IBarkUI;
            if (cachedState == null) PopulateCache(speaker, listener);
            BarkNextCachedLine(speaker, listener);
        }
        protected void PopulateCache(Transform speaker, Transform listener)
        {
            if (string.IsNullOrEmpty(barkConversation) && DialogueDebug.logWarnings) Debug.Log(string.Format("{0}: Bark (speaker={1}, listener={2}): conversation title is blank", new System.Object[] { DialogueDebug.Prefix, speaker, listener }), speaker);
            ConversationModel conversationModel = new ConversationModel(DialogueManager.masterDatabase, barkConversation, speaker, listener, DialogueManager.allowLuaExceptions, DialogueManager.isDialogueEntryValid);
            cachedState = conversationModel.firstState;
            if ((cachedState == null) && DialogueDebug.logWarnings) Debug.Log(string.Format("{0}: Bark (speaker={1}, listener={2}): '{3}' has no START entry", new System.Object[] { DialogueDebug.Prefix, speaker, listener, barkConversation }), speaker);
            if (!cachedState.hasAnyResponses && DialogueDebug.logWarnings) Debug.Log(string.Format("{0}: Bark (speaker={1}, listener={2}): '{3}' has no valid bark lines", new System.Object[] { DialogueDebug.Prefix, speaker, listener, barkConversation }), speaker);
        }
        protected void BarkNextCachedLine(Transform speaker, Transform listener)
        {
            if ((barkUI != null) && (cachedState != null) && cachedState.hasAnyResponses)
            {
                Response[] responses = cachedState.hasNPCResponse ? cachedState.npcResponses : cachedState.pcResponses;
                int index = (barkHistory ?? new BarkHistory(BarkOrder.Random)).GetNextIndex(responses.Length);
                DialogueEntry barkEntry = responses[index].destinationEntry;
                if ((barkEntry == null) && DialogueDebug.logWarnings) Debug.Log(string.Format("{0}: Bark (speaker={1}, listener={2}): '{3}' bark entry is null", new System.Object[] { DialogueDebug.Prefix, speaker, listener, conversation }), speaker);
                if (barkEntry != null)
                {
                    Subtitle subtitle = new Subtitle(cachedState.subtitle.listenerInfo, cachedState.subtitle.speakerInfo, new FormattedText(barkEntry.currentDialogueText), string.Empty, string.Empty, barkEntry);
                    if (DialogueDebug.logInfo) Debug.Log(string.Format("{0}: Bark (speaker={1}, listener={2}): '{3}'", new System.Object[] { DialogueDebug.Prefix, speaker, listener, subtitle.formattedText.text }), speaker);
                    StartCoroutine(BarkController.Bark(subtitle, speaker, listener, barkUI));
                }
            }
        }
        /// <summary>
        /// Resets the bark history to the beginning of the list of bark lines.
        /// </summary>
        public void ResetBarkHistory()
        {
            barkHistory.Reset();
        }
        #endregion
        #region Conversation Action
        protected virtual void DoConversationAction(Transform actor)
        {
            if (string.IsNullOrEmpty(conversation)) return;
            if (skipIfNoValidEntries && !DialogueManager.ConversationHasValidEntry(conversation, Tools.Select(conversationActor, actor), Tools.Select(conversationConversant, this.transform)))
            {
                if (DialogueDebug.logInfo) Debug.Log("Dialogue System: Conversation triggered on " + name + " but skipping because no entries are currently valid.", this);
            }
            else if (exclusive && DialogueManager.isConversationActive)
            {
                if (DialogueDebug.logInfo) Debug.Log("Dialogue System: Conversation triggered on " + name + " but skipping because another conversation is active.", this);
            }
            else
            {
                var actorTransform = Tools.Select(conversationActor, actor);
                var conversantTransform = conversationConversant;
                if (conversantTransform == null)
                {
                    var conversationAsset = DialogueManager.MasterDatabase.GetConversation(conversation);
                    var conversationConversantActor = DialogueManager.MasterDatabase.GetActor(conversationAsset.ConversantID);
                    var registeredTransform = (conversationConversantActor != null) ? CharacterInfo.GetRegisteredActorTransform(conversationConversantActor.Name) : null;
                    conversantTransform = (registeredTransform != null) ? registeredTransform : this.transform;
                }
                DialogueManager.StartConversation(conversation, actorTransform, conversantTransform);
                earliestTimeToAllowTriggerExit = Time.time + MarginToAllowTriggerExit;
                if (stopConversationIfTooFar)
                {
                    monitorDistanceCoroutine = StartCoroutine(MonitorDistance(DialogueManager.currentActor));
                }
            }
        }
        protected void StopMonitoringConversationDistance()
        {
            if (monitorDistanceCoroutine != null) StopCoroutine(monitorDistanceCoroutine);
            monitorDistanceCoroutine = null;
        }
        protected IEnumerator MonitorDistance(Transform actor)
        {
            if (actor == null) yield break;
            Transform myTransform = transform;
            while (true)
            {
                yield return StartCoroutine(DialogueTime.WaitForSeconds(monitorConversationDistanceFrequency));
                if (Vector3.Distance(myTransform.position, actor.position) > maxConversationDistance)
                {
                    if (DialogueDebug.logInfo) Debug.Log(string.Format("{0}: Stopping conversation. Exceeded max distance {1} between {2} and {3}", new System.Object[] { DialogueDebug.Prefix, maxConversationDistance, name, actor.name }));
                    DialogueManager.StopConversation();
                    yield break;
                }
            }
        }
        #endregion
        #region Set GameObject Active Action
        protected virtual void DoSetActiveActions(Transform actor)
        {
            for (int i = 0; i < setActiveActions.Length; i++)
            {
                var action = setActiveActions[i];
                if (action != null && action.condition != null && action.condition.IsTrue(actor))
                {
                    var target = Tools.Select(action.target, this.transform);
                    bool newValue = ToggleUtility.GetNewValue(target.gameObject.activeSelf, action.state);
                    if (DialogueDebug.logInfo) Debug.Log(string.Format("{0}: Trigger: {1}.SetActive({2})", new System.Object[] { DialogueDebug.Prefix, target.name, newValue }));
                    target.gameObject.SetActive(newValue);
                }
            }
        }
        #endregion
        #region Set Components Enabled Action
        protected virtual void DoSetEnabledActions(Transform actor)
        {
            for (int i = 0; i < setEnabledActions.Length; i++)
            {
                var action = setEnabledActions[i];
                if (action != null && action.condition != null && action.condition.IsTrue(actor))
                {
                    Tools.SetComponentEnabled(action.target, action.state);
                }
            }
        }
        #endregion
        #region Set Animator State Action
        protected virtual void DoSetAnimatorStateActions(Transform actor)
        {
            for (int i = 0; i < setAnimatorStateActions.Length; i++)
            {
                var action = setAnimatorStateActions[i];
                if (action != null && action.condition != null && action.condition.IsTrue(actor))
                {
                    Transform target = Tools.Select(action.target, this.transform);
                    Animator animator = target.GetComponentInChildren<Animator>();
                    if (animator == null)
                    {
                        if (DialogueDebug.logWarnings) Debug.Log(string.Format("{0}: Trigger: {1}.SetAnimatorState() can't find Animator", new System.Object[] { DialogueDebug.Prefix, target.name }));
                    }
                    else
                    {
                        if (DialogueDebug.logInfo) Debug.Log(string.Format("{0}: Trigger: {1}.SetAnimatorState({2})", new System.Object[] { DialogueDebug.Prefix, target.name, action.stateName }));
                        animator.CrossFade(action.stateName, action.crossFadeDuration);
                    }
                }
            }
        }
        #endregion
        #region Save & Load
        /// <summary>
        /// Listens for the OnRecordPersistentData message and records the current bark index.
        /// </summary>
        public void OnRecordPersistentData()
        {
            if (enabled && !string.IsNullOrEmpty(barkConversation))
            {
                DialogueLua.SetActorField(GetBarkerName(), "Bark_Index", barkHistory.index);
            }
        }
        /// <summary>
        /// Listens for the OnApplyPersistentData message and retrieves the current bark index.
        /// </summary>
        public void OnApplyPersistentData()
        {
            if (enabled && !string.IsNullOrEmpty(barkConversation))
            {
                if (barkHistory == null) barkHistory = new BarkHistory(barkOrder);
                barkHistory.index = DialogueLua.GetActorField(GetBarkerName(), "Bark_Index").asInt;
            }
        }
        #endregion
    }
}

[Tony Li]

Hi,

What errors does it give?

Can you update to Dialogue System version 2.2.7 and then import the patch?

[joshualoveridge]

Sorry Toni, updating is a no go as we are so close to release, im really looking for a patch solution just to get us by
any ideas?

[joshualoveridge]

it gives errors about the bark group namespace not existing

[Tony Li]

In that case, revert to your working version of DialogueSystemTrigger and make these changes:

1. At the end of the Start() method, add this code:

Code: Select all

if (cacheBarkLines && barkSource == BarkSource.Conversation && !string.IsNullOrEmpty(barkConversation))
{
    PopulateCache(GetBarker(barkConversation), barkTarget);
}

2. In the BarkNextCachedLine() method, locate the line that starts with "Subtitle subtitle = ...". Change it to:

Code: Select all

Subtitle subtitle = new Subtitle(cachedState.subtitle.listenerInfo, cachedState.subtitle.speakerInfo, new FormattedText(barkEntry.currentDialogueText), barkEntry.currentSequence, string.Empty, barkEntry);