ORK Framework 3 Integration

[RustedGames]

Hello Tony,
When making the video tutorial I found under the ORKGiveExpQuestAction.cs script line 90 the order of the parameters are wrong

Code: Select all

statusValue.AddValue(value, false, false, true, false, ignoreLimit, ignoreBarrier, showFlyingText, new StatusValueChangeSource(null, combatant));

whereas it should be

Code: Select all

statusValue.AddValue(value, false, false, false, ignoreLimit, ignoreBarrier, showFlyingText, false, new StatusValueChangeSource(null, combatant));

I also changed the "checkLevelUp" flag to "false", otherwise the result of Adding the status value was unpredictable, (not sure if it is also a ORK3 bug though)

Code: Select all

statusValue.AddValue(
                   addValue:value, 
                   isCritical: false,
                   checkDeath: false,
                   checkLevelUp: false, 
                   ignoreLimit: ignoreLimit, 
                   ignoreBarrier: ignoreBarrier,
                   showFlyingText: showFlyingText, 
                   showConsole: false,
                   source: new StatusValueChangeSource(null, combatant));

I couldn't find how its being used in the ORK 3 source code, I might ask GamingIslove about it.

Best regards

[Tony Li]

Hi,

Thanks. The ORK integration had gotten out of date. I made the same change that you did below, except I added a checkLevelUp inspector property that you can set to false. (It defaults to true.) This update will be in the next Quest Machine release.