Dialogue doesn't close when spamming continue.

[WeakInteractive]

Hello,

I'm experiencing an issue where if I press the continue button too fast, the subtitle panels don't close. I'm using the "Bubble Template Standard UI Subtitle Panel." I've attached a repro project that was made to demonstrate the issue. It's not difficult to reproduce.

Repro steps to see the issue in the attached project:

1. Press the Play button to enter Play Mode.
2. Press the enter key as fast as possible.
3. Observe how the subtitle panels remain open after the conversation has ended.

I'm fairly certain it's not me that is doing something wrong, because pressing the continue button slowly closes the subtitle panels as expected.

In the example project, I've only imported the "Dialogue System for Unity" package, and the Bubble UI Patch found here: https://www.pixelcrushers.com/phpbb/vie ... 8&start=10

I don't think the issue is related to the patch, as I experienced a similar issue without the patch

The ZIP file of the repro project is too large to directly attach here, so I've uploaded it onto google drive:
[removed]

Any assistance with this would be greatly appreciated. If you need any additional information, please let me know.

Thank you.

[Tony Li]

Hi,

I'm downloading the project now, and I'll reply back with an answer.

p.s. - In the future, please don't publicly post a download link of the Dialogue System. You're welcome to send a link via PM or email directly to tony (at) pixelcrushers.com

[WeakInteractive]

Woops, that's my bad, sorry about that. Please let me know if you need the link again, I'll send it by email.

[Tony Li]

No, all's fine. I should have a patch ready shortly.

[Tony Li]

Hi,

Please use this patch:

[see below]

The issue was with custom panels (e.g., bubble panels), which should now always get the message to close when they're supposed to close.

[WeakInteractive]

Hello,

Thanks for getting back to me so quickly.

Unfortunately, after testing out the patch, it seems to undo the fix for this patch: https://www.pixelcrushers.com/phpbb/vie ... 8&start=10

It also only seems to partially solve the issue. No dialogue text/bubbles are visible after spamming continue, but the Dialogue Subtitle Panel of the last speaking actor remains active for around 10 seconds, which means the continue button is still visible for that time. This behavior is only when spamming.

Please let me know if you would like any video examples, or another repro project.

Once again, thank you for the assistance, and I look forward to your reply.

[Tony Li]

Sounds like I may have made an export error. Unlike regular releases, which use automated packaging and regression testing, patches are usually exported manually. I'll check it first thing in the morning.

[WeakInteractive]

Thanks!

[Tony Li]

Okay, this one should be packed up properly:

DS_BubblePanelPatch_2021-09-26.unitypackage

If you still see an issue, just let me know and I'll look into it.

A side note about the continue button: You may want to include it in the panel's fade in/out animation, depending on your vision for your UI design.

[WeakInteractive]

Hello!

I've just tested out the patch, and everything seems to be working great!

Thanks for the tip about the continue button. Now that I think about it, it was kind of dumb to say that the continue button was still visible when I should have just made it fade out. The continue button in my game is always invisible, so I hadn't given this much thought.

Thanks for the help!