Page 1 of 2

New Warnings with Unity2017

Posted: Tue Apr 25, 2017 10:27 am
by HawkX
Hi just upgraded to the new unity 2017... (so many amazing improvements!!)

However, i noticed that 2 of Dialogue System now give me warnings... which i obviously dont understand ;)

Here are the console logs :

Code: Select all

Animator is not playing an AnimatorController
UnityEngine.Animator:GetCurrentAnimatorStateInfo(Int32)
PixelCrushers.DialogueSystem.<WaitForAnimation>c__Iterator0:MoveNext() (at Assets/Dialogue System/Scripts/Supplemental/UI/Tools/UIShowHideController.cs:63)
and

Code: Select all

Animator is not playing an AnimatorController
UnityEngine.Animator:GetCurrentAnimatorStateInfo(Int32)
PixelCrushers.DialogueSystem.<WaitForAnimation>c__Iterator0:MoveNext() (at Assets/Dialogue System/Scripts/Supplemental/UI/Tools/UIShowHideController.cs:67)
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
and those 2 lines are :
currentHashID = UITools.GetAnimatorNameHash(animator.GetCurrentAnimatorStateInfo(0));
and
var clipLength = animator.GetCurrentAnimatorStateInfo(0).length;

Since they are just warnings, nothing seems broken and everything still seems to be working fine :)

Just thought i'd let you know... if you did not already :)

EDIT : and while im writing... the "conversation window" is semi-broken now... if you scroll down to zoom out, the available window does not resize properly... here is a screenshot, you see the "grey" area should be "darker grey like the top left part"
Image

Re: New Warnings with Unity2017

Posted: Tue Apr 25, 2017 2:11 pm
by Tony Li
Hi,

Thanks for reporting these issues. I aim to address them in a Dialogue System update by the time Unity 2017 comes out of beta if not before.

For the editor canvas issue in the meantime, if you lock the zoom at 1.0 it should work correctly except that you can't zoom out of course.

Re: New Warnings with Unity2017

Posted: Tue Apr 25, 2017 3:24 pm
by HawkX
Yeah i noticed if i zoom back in the bug is gone... just though i'd mention it :)

Since i am using lots of MP4 video files along with the new "video player", i always updates whenever they have a new version... and the new additions (fixes) to the anim systems are really great as well :) -- They also fixed drag and drop of multiple items into lists (they will now always be in order)

Re: New Warnings with Unity2017

Posted: Tue Apr 25, 2017 4:27 pm
by Tony Li
Thanks. I try to keep the Dialogue System ahead of the curve on Unity versions. Unfortunately there's a backlog right now of other tasks first. Every Asset Store developer updated their assets in preparation for the ongoing store-wide sale, and Nevigo recently released a big overhaul to articy:draft, so I have to update a lot of third party integrations first.

Re: New Warnings with Unity2017

Posted: Tue Apr 25, 2017 4:31 pm
by HawkX
haha no rush! :)

you are already doing a better job than at LEAST 95% of all who are on the store!! :)

I am probably not even running the latest version of the Dialogue System... did not really know "how" to upgrade and always put it for later ;)

Re: New Warnings with Unity2017

Posted: Tue Apr 25, 2017 10:30 pm
by Tony Li
You can see what version you're running by selecting menu item Window > Dialogue System > Help > About or inspecting the file Assets / Dialogue System / _README.txt.

Upgrading is simple: Just import the latest version of the Dialogue System. I try to be as careful as possible to avoid compatibility issues across versions, so it should just work. To be safe, though, always make a backup before upgrading any Asset Store package, including the Dialogue System.

Re: New Warnings with Unity2017

Posted: Wed Apr 26, 2017 2:07 pm
by HawkX
Thanks for the great tips as always! :)

I wanted to ask... (NOT URGENT), if its possible, I would love for the mouse wheel to work in the conversation database... I have already more than my monitor height allows... and i need to use the mouse with little arrow up and down to scroll... i only have a few more for now... but I also only have about 10% of my dialogues in the game yet ;) Being able to scroll with the mouse would be really nice!

Re: New Warnings with Unity2017

Posted: Wed Apr 26, 2017 2:23 pm
by Tony Li
Hi,

Which tabs are you referring to? The Conversations tab or the other tabs?

Re: New Warnings with Unity2017

Posted: Wed Apr 26, 2017 2:53 pm
by HawkX
This drop down menu to select conversations :)

Image

Re: New Warnings with Unity2017

Posted: Wed Apr 26, 2017 3:10 pm
by Tony Li
Can you change the conversation titles to use forward slashes? The example in the manual is:
  • Companions/Robot Butler/At Your Service
  • Companions/Robot Butler/Malfunction
  • Desert/Scavenger
  • Desert/Scorpion Herder
  • Jungle/Shaman, etc.
This will group them into submenus "Companions", "Desert", and "Jungle" in the Dialogue Editor, making it much easier to select conversations. The "Companions" submenu will have a sub-submenu for "Robot Butler", containing a conversation "Malfunction".

In your example, you could group a bunch of conversations under "Jenny/" such as "Jenny/Jenny0CS1", "Jenny/Jenny02", "Jenny/Jenny03", etc.

The conversation selection dropdown is handled entirely by Unity, which doesn't expose a way for custom editors to change its behavior. However, Unity is soliciting feedback on editor usability improvements. You could suggest mouse wheel scroll for dropdown menus:

[Official] Unity wants your feedback on usability and artist workflows!