Page 1 of 2

Celtx import - Existing Breakdown fields of different custom types

Posted: Wed Apr 26, 2023 6:28 am
by cbrito
Hey Tony,

We've found a bug, or unexpected behavior in the celtx import related to shared breakdown fields with different custom types. Here's the steps to reproduce
  • Create two different Custom Types
    Add a first breakdown of the first custom type
    Add a second breakdown field of the second custom type, but select the last added field in the existing dropdown
    Export project and import it to the Dialogue System
    Both dialogue nodes will have the two breakdown fields with the same custom type as key.
I've added some screenshots and a JSON that reproduces the bug.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Wed Apr 26, 2023 9:12 pm
by Tony Li
Thank you for the detailed explanation and data. I'll try to have a fix for you by tomorrow. It will also include the earlier change you requested that sets the Celtx ID field of sequence nodes to the node's ID instead of the parent sequence's ID.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Wed Apr 26, 2023 10:38 pm
by Tony Li
Hi! I believe this patch should fix the issue:

DS_GemPatch_2023-04-26.unitypackage

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu Apr 27, 2023 3:57 am
by cbrito
Hi Tony!

The patch fixed the Field key issue, but unfortunately the first node Field valeu is wrong. The second is correct.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu Apr 27, 2023 4:30 am
by cbrito
Hi again!

We updated Dialogue System for version 2.2.35 (we were on 2.2.33) to test the patch and apparently the importer is not importing conditions anymore. Is this issue known?

I've added a JSON with an example.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu Apr 27, 2023 10:54 am
by Tony Li
Hi,

I'll look into this today and get back to you as soon as I can.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Tue May 02, 2023 12:23 pm
by Tony Li
Hi,

This patch should resolve both issues:

DS_GemPatch_2023-05-02.unitypackage

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu May 04, 2023 8:56 am
by cbrito
Hi Tony!

We tested the lastest Dialogue System version with the patch and we have the celtx dialogue id in each node and conditions are fixed.

Although the breakdown field issue in the example, we replicated the issue in a different situation.

We were able to fix the issue ourselves. See if the following patch makes sense to you.

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu May 04, 2023 10:05 am
by Tony Li
Hi,

That doesn't appear to work correctly. When importing your "Script Bug - Existing Breakdown Field With Different Custom Type.json" file, it imports the values like this:

gemCustomType.png
gemCustomType.png (22.63 KiB) Viewed 1397 times

Re: Celtx import - Existing Breakdown fields of different custom types

Posted: Thu May 04, 2023 12:18 pm
by cbrito
Hi!

That's what we intended given the Celtx project I showed you in the first message :)