Page 1 of 2
Bubble stuck in Hide state
Posted: Tue Sep 21, 2021 5:44 am
by igorsandman
Hello,
I'm having trouble with the bubble template.
When I press the skip button twice fast, the animator of the bubble remains stuck in the Hide state.
Is there an issue with the way the animator controller is setup?
Re: Bubble stuck in Hide state
Posted: Tue Sep 21, 2021 9:00 am
by Tony Li
Hi,
If Visibility is set to Until Superceded, the bubble won't hide if the next line will use the same bubble, so there won't be a Hide timing issue.
Otherwise, if you need it set to Only During Content, tick Wait For Close.
Re: Bubble stuck in Hide state
Posted: Tue Sep 21, 2021 10:31 am
by igorsandman
Hi,
Ticking Wait for Close gives me a null reference error that I don't get with it left unticked:
Code: Select all
NullReferenceException: Object reference not set to an instance of an object
PixelCrushers.DialogueSystem.StandardUISubtitlePanel.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitlePanel.cs:225)
PixelCrushers.DialogueSystem.StandardUISubtitleControls.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitleControls.cs:353)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:176)
PixelCrushers.DialogueSystem.ConversationView.StartSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle, System.Boolean isPCResponseMenuNext, System.Boolean isPCAutoResponseNext) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:141)
PixelCrushers.DialogueSystem.ConversationController.GotoState (PixelCrushers.DialogueSystem.ConversationState state) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:208)
PixelCrushers.DialogueSystem.ConversationController.OnFinishedSubtitle (System.Object sender, System.EventArgs e) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:264)
PixelCrushers.DialogueSystem.ConversationView.FinishSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:399)
PixelCrushers.DialogueSystem.ConversationView.HandleContinueButtonClick () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:371)
PixelCrushers.DialogueSystem.ConversationView.OnConversationContinue (PixelCrushers.DialogueSystem.IDialogueUI dialogueUI) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:354)
UnityEngine.Component:SendMessage(String, Object, SendMessageOptions)
PixelCrushers.DialogueSystem.AbstractDialogueUI:OnContinueConversation() (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Abstract/Dialogue/AbstractDialogueUI.cs:366)
PixelCrushers.DialogueSystem.StandardUISubtitlePanel:OnContinue() (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitlePanel.cs:447)
UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction`1)
Rewired.Integration.UnityUI.RewiredStandaloneInputModule:SendSubmitEventToSelectedObject() (at Assets/Rewired/Integration/UnityUI/RewiredStandaloneInputModule.cs:830)
Rewired.Integration.UnityUI.RewiredStandaloneInputModule:Process() (at Assets/Rewired/Integration/UnityUI/RewiredStandaloneInputModule.cs:685)
UnityEngine.EventSystems.EventSystem:Update() (at C:/Program Files/Unity/Hub/Editor/2019.4.0f1/Editor/Data/Resources/PackageManager/BuiltInPackages/com.unity.ugui/Runtime/EventSystem/EventSystem.cs:377)
I suppose I need to assign some variable for it to work?
Re: Bubble stuck in Hide state
Posted: Tue Sep 21, 2021 10:39 am
by Tony Li
Hi,
Would you please back up your project and update to the latest version of the Dialogue System? That way we'll have the same line numbers and I'll be better able to help you.
Re: Bubble stuck in Hide state
Posted: Wed Sep 22, 2021 3:28 am
by igorsandman
Hi,
I updated the asset and the error is still there except it doesn't display anything in the log now.
The game freezes on the first line of text like it did before, except now the error isn't displayed anymore.
Re: Bubble stuck in Hide state
Posted: Wed Sep 22, 2021 5:30 am
by igorsandman
After further testing it seems it was a mistake on my end that as causing the freeze. Now it doesn't freeze anymore when I tick Wait For Close, but it doesn't prevent the Animator on the bubble to get stuck in Hide state.
Re: Bubble stuck in Hide state
Posted: Wed Sep 22, 2021 8:31 am
by Tony Li
Just making sure -- it's working correctly now?
Re: Bubble stuck in Hide state
Posted: Wed Sep 22, 2021 12:06 pm
by igorsandman
Hi,
No, the animator is still getting stuck in Hide state when I press fast, even with Wait for Close ticked.
Re: Bubble stuck in Hide state
Posted: Wed Sep 22, 2021 1:20 pm
by Tony Li
Would you please send a
reproduction project to tony (at) pixelcrushers.com along with the steps I should follow to reproduce the issue?
Re: Bubble stuck in Hide state
Posted: Thu Sep 23, 2021 5:44 am
by igorsandman
Hi,
If you reproduce the steps I explained in issue 1 here:
https://www.pixelcrushers.com/phpbb/vie ... 317#p27317
then mash the submit button you'll will see the animator gets stuck.
I'd like to avoid having to create a scene if at all possible since the issues should easy to reproduce.
If you can't reproduce, I'll make a reproduction project.
Thanks