Bubble stuck in Hide state

Announcements, support questions, and discussion for the Dialogue System.
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Bubble stuck in Hide state

Post by igorsandman »

Hello,
I'm having trouble with the bubble template.
When I press the skip button twice fast, the animator of the bubble remains stuck in the Hide state.

Is there an issue with the way the animator controller is setup?
User avatar
Tony Li
Posts: 21984
Joined: Thu Jul 18, 2013 1:27 pm

Re: Bubble stuck in Hide state

Post by Tony Li »

Hi,

If Visibility is set to Until Superceded, the bubble won't hide if the next line will use the same bubble, so there won't be a Hide timing issue.

Otherwise, if you need it set to Only During Content, tick Wait For Close.
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Re: Bubble stuck in Hide state

Post by igorsandman »

Hi,
Ticking Wait for Close gives me a null reference error that I don't get with it left unticked:

Code: Select all

NullReferenceException: Object reference not set to an instance of an object
PixelCrushers.DialogueSystem.StandardUISubtitlePanel.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitlePanel.cs:225)
PixelCrushers.DialogueSystem.StandardUISubtitleControls.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitleControls.cs:353)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:176)
PixelCrushers.DialogueSystem.ConversationView.StartSubtitle (PixelCrushers.DialogueSystem.Subtitle subtitle, System.Boolean isPCResponseMenuNext, System.Boolean isPCAutoResponseNext) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:141)
PixelCrushers.DialogueSystem.ConversationController.GotoState (PixelCrushers.DialogueSystem.ConversationState state) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:208)
PixelCrushers.DialogueSystem.ConversationController.OnFinishedSubtitle (System.Object sender, System.EventArgs e) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:264)
PixelCrushers.DialogueSystem.ConversationView.FinishSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:399)
PixelCrushers.DialogueSystem.ConversationView.HandleContinueButtonClick () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:371)
PixelCrushers.DialogueSystem.ConversationView.OnConversationContinue (PixelCrushers.DialogueSystem.IDialogueUI dialogueUI) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:354)
UnityEngine.Component:SendMessage(String, Object, SendMessageOptions)
PixelCrushers.DialogueSystem.AbstractDialogueUI:OnContinueConversation() (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Abstract/Dialogue/AbstractDialogueUI.cs:366)
PixelCrushers.DialogueSystem.StandardUISubtitlePanel:OnContinue() (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUISubtitlePanel.cs:447)
UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction`1)
Rewired.Integration.UnityUI.RewiredStandaloneInputModule:SendSubmitEventToSelectedObject() (at Assets/Rewired/Integration/UnityUI/RewiredStandaloneInputModule.cs:830)
Rewired.Integration.UnityUI.RewiredStandaloneInputModule:Process() (at Assets/Rewired/Integration/UnityUI/RewiredStandaloneInputModule.cs:685)
UnityEngine.EventSystems.EventSystem:Update() (at C:/Program Files/Unity/Hub/Editor/2019.4.0f1/Editor/Data/Resources/PackageManager/BuiltInPackages/com.unity.ugui/Runtime/EventSystem/EventSystem.cs:377)
I suppose I need to assign some variable for it to work?
User avatar
Tony Li
Posts: 21984
Joined: Thu Jul 18, 2013 1:27 pm

Re: Bubble stuck in Hide state

Post by Tony Li »

Hi,

Would you please back up your project and update to the latest version of the Dialogue System? That way we'll have the same line numbers and I'll be better able to help you.
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Re: Bubble stuck in Hide state

Post by igorsandman »

Hi,
I updated the asset and the error is still there except it doesn't display anything in the log now.
The game freezes on the first line of text like it did before, except now the error isn't displayed anymore.
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Re: Bubble stuck in Hide state

Post by igorsandman »

After further testing it seems it was a mistake on my end that as causing the freeze. Now it doesn't freeze anymore when I tick Wait For Close, but it doesn't prevent the Animator on the bubble to get stuck in Hide state.
User avatar
Tony Li
Posts: 21984
Joined: Thu Jul 18, 2013 1:27 pm

Re: Bubble stuck in Hide state

Post by Tony Li »

Just making sure -- it's working correctly now?
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Re: Bubble stuck in Hide state

Post by igorsandman »

Hi,
No, the animator is still getting stuck in Hide state when I press fast, even with Wait for Close ticked.
User avatar
Tony Li
Posts: 21984
Joined: Thu Jul 18, 2013 1:27 pm

Re: Bubble stuck in Hide state

Post by Tony Li »

Would you please send a reproduction project to tony (at) pixelcrushers.com along with the steps I should follow to reproduce the issue?
igorsandman
Posts: 35
Joined: Fri Jul 09, 2021 9:50 am

Re: Bubble stuck in Hide state

Post by igorsandman »

Hi,
If you reproduce the steps I explained in issue 1 here: https://www.pixelcrushers.com/phpbb/vie ... 317#p27317
then mash the submit button you'll will see the animator gets stuck.

I'd like to avoid having to create a scene if at all possible since the issues should easy to reproduce.
If you can't reproduce, I'll make a reproduction project.
Thanks
Post Reply