Page 1 of 1

Comment sequence line

Posted: Thu Jul 04, 2019 9:37 am
by Maltakreuz
1. I would like to comment some lines in sequence for debug purposes. I have tried lua style --, but it does not work. Is any way to do that? (Multiline comments would be nice too)

2. I also tried // style comments. And it makes game and unity editor completly freeze. Actually any not defined command/typo in sequence will cause a complete unity freeze. It is pretty unconvinient by writing sequences/debugging. It would be better sequence parser will throw exception like "unknon command". Is any way to prevent this freezes? (unity 2018.2.14, dialogue system 2.1.7)

Re: Comment sequence line

Posted: Thu Jul 04, 2019 10:48 am
by Tony Li
Please update to version 2.1.8. The freeze bug was introduced in 2.1.7 and fixed in 2.1.8.

I have also wanted to comment out sequences on occasion. I'll add it to the roadmap, hopefully for 2.1.9.

Re: Comment sequence line

Posted: Thu Jun 18, 2020 4:03 pm
by VoodooDetective
Just curious if this was added?

Re: Comment sequence line

Posted: Thu Jun 18, 2020 4:33 pm
by Tony Li
No, I pushed it to the backlog list and forgot it there. Sorry about that. I *will* try to get it into the next update. In the meantime, you could write a sequencer command that does nothing, something like:

SequencerCommandComment.cs

Code: Select all

using UnityEngine;
using System.Collections;
using PixelCrushers.DialogueSystem;

namespace PixelCrushers.DialogueSystem.SequencerCommands
{
    public class SequencerCommandComment : SequencerCommand
    {
        private void Awake() { Stop(); }
    }
}
and then use it like this:

Code: Select all

Camera(Closeup,speaker);
Comment(In two seconds, do a wide shot of the listener);
Camera(Wide,listener)

Re: Comment sequence line

Posted: Fri Jun 19, 2020 3:25 pm
by VoodooDetective
Ah ok, it's no big deal. Just curious :)
Thanks!