Page 24 of 26

Re: ORK integration

Posted: Thu Oct 31, 2024 7:35 am
by Tony Li
Hi,

My example code above treats any quest that isn't procedurally generated as being "bugged":

Code: Select all

bool isBugged = !quest.isProcedurallyGenerated;
I wasn't sure exactly what your criteria were for determining if a quest is bugged. You can change this line, or remind me what's identifiable about a bugged quest and I'll try to provide the right line of code for it.

Re: ORK integration

Posted: Thu Oct 31, 2024 7:52 am
by dlevel
I gavent changed anything on ORKQuestMachineSaveData, the issue now is that provably quest machine tries to load the quest from ORKQuestMachineSaveData while previously were saced via quest journal maybe?

So trying to resolve this first before going changing ORKQuestMachineSaveData to fix bugged quests

Re: ORK integration

Posted: Thu Oct 31, 2024 10:12 am
by Tony Li
Hi,

I think both components (ORKQuestMachineSaveData and QuestJournalForORK) were saving the quest data. So it should be okay to tick that checkbox on QuestJournalForORK and rely only on ORKQuestMachineSaveData's copy of the quest data.

Re: ORK integration

Posted: Thu Oct 31, 2024 12:17 pm
by dlevel
It seems that Journal was saving, since checking this option on the new Journal, it doesnt load any of the player's quests. So, it will work for new saves, but the old saves are doomed this way :D

Re: ORK integration

Posted: Thu Oct 31, 2024 4:50 pm
by Tony Li
Okay, so to confirm:

1. With the QuestJournalForORK's "Allow ORK Quest Machine Save Data To Save" checkbox ticked, newly saved games work, and they save through the ORKQuestMachineSaveData component on the Quest Machine GameObject.

2. However, old saved games do not restore any quests at all?

Is that correct?

Re: ORK integration

Posted: Fri Nov 01, 2024 7:18 am
by dlevel
correct

Re: ORK integration

Posted: Fri Nov 01, 2024 7:44 am
by Tony Li
To handle old saved games, I think we can check if QuestJournalForORK has saved data. If so, we use it to restore the player's quest journal, and then we reset "bad" quests.

If the saved game doesn't have QuestJournalForORK data, then we should know that it's saved through ORKQuestMachineSaveData, and we don't need to do anything.

Does that make sense? If so, I can put together a script to do that.

Re: ORK integration

Posted: Fri Nov 01, 2024 8:34 am
by dlevel
yes that would work very well

Re: ORK integration

Posted: Fri Nov 01, 2024 9:36 am
by Tony Li
Alright, I'll put together a script to try today.

Please remind me: How can we tell if a quest is in a bad state? And do you want to remove this quest from the journal or reset it to a "just accepted" state?

Re: ORK integration

Posted: Sat Nov 02, 2024 3:14 pm
by dlevel
So a bad state in quest is when I see the headline only, and no state/requirements on the quest, its also showing black in journal but its not finished, you can see the screenshots in my previous posts. I d like them to be removed and I ll handle them later on how player will get them again. Thank you for your help on this