[Bugs] Reorder ID's and Conversation Menu Settings

[Unrighteous]

Hello,

I have been experiencing two possible bugs.

The first is that reordering conversation ID's doesn't seem to work sometimes, and can have catastrophic results. When I tried using "Reorder ID's -> All Conversations," one of my huge conversations had nearly all of its links/transitions changed to different nodes.

I also get an error when trying to reorder ID's with "Depth First Reordering" unticked. I'll post the error text at the bottom.

The second possible bug is that the menu tick options in the Conversations tab of the Dialogue Editor don't seem to save. Switching Unity editor layouts or closing/opening the Dialogue Editor resets different options. I tried changing the default bool states in the source code, but that didn't fully solve the issue. In the end, I wound up modifying the code to do what I wanted regardless of the bool states. I managed to figure out how to do that, but that's the limit of my coding ability, I'm completely clueless as to why the options don't save.

I have workarounds for both issues, so I'm not urgently anticipating any fixes.

Thank you.

Unity 2020.3.43f1
Dialogue System for Unity 2.2.35

Error:
ArgumentException: An item with the same key has already been added. Key: 3
System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Collections.Generic.Dictionary`2[TKey,TValue].Add (TKey key, TValue value) (at <695d1cc93cca45069c528c15c9fdd749>:0)
PixelCrushers.DialogueSystem.DialogueEditor.DialogueEditorWindow.ReorderNodes (PixelCrushers.DialogueSystem.Conversation conversation) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/Editor/Dialogue Editor/DialogueEditorWindowReorderIDs.cs:316)
PixelCrushers.DialogueSystem.DialogueEditor.DialogueEditorWindow.ReorderIDsInConversationAlternateMethod (PixelCrushers.DialogueSystem.Conversation conversation) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/Editor/Dialogue Editor/DialogueEditorWindowReorderIDs.cs:168)
PixelCrushers.DialogueSystem.DialogueEditor.DialogueEditorWindow.ReorderIDsInConversation (PixelCrushers.DialogueSystem.Conversation conversation) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/Editor/Dialogue Editor/DialogueEditorWindowReorderIDs.cs:64)
PixelCrushers.DialogueSystem.DialogueEditor.DialogueEditorWindow.ReorderIDsThisConversationNow () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/Editor/Dialogue Editor/DialogueEditorWindowReorderIDs.cs:30)
PixelCrushers.DialogueSystem.DialogueEditor.DialogueEditorWindow.ConfirmReorderIDsThisConversation () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/Editor/Dialogue Editor/DialogueEditorWindowReorderIDs.cs:23)
UnityEditor.GenericMenu.CatchMenu (System.Object userData, System.String[] options, System.Int32 selected) (at <6a4b923691b54d0eb965a9ed2a807ce9>:0)

[Tony Li]

Hi,

That error message means that, in one of your conversations, two nodes have the same internal ID number. This shouldn't happen. I'll add a check to handle it gracefully.

Regarding the Dialogue Editor's Conversations section > Menu > Show > options, they currently aren't designed to last across Dialogue Editor window sessions. I'm going to change that in one of the next few updates, since it would probably be handy to make those persist until you change them.