after updating from 2.2.21 to 2.2.30 - getting a crash on this

[fkkcloud]

Hi,

After updating from 2.2.21 to 2.2.30 - getting a crash on this.

1111.png (169.28 KiB) Viewed 731 times

123123.png (12.53 KiB) Viewed 731 times

it seems like I dont connect the player input directly to the very first <Start> node, it does not do that though

[Tony Li]

Hi,

Please temporarily comment out these lines in AbstractDialogueUI.cs:

debugShowResponses.png (66.91 KiB) Viewed 723 times

Then reproduce the error and reply with the new error info.

[fkkcloud]

Here it is:

NullReferenceException: Object reference not set to an instance of an object
PixelCrushers.UIPanel.SetFocus (UnityEngine.GameObject selectable) (at Assets/Plugins/Pixel Crushers/Common/Scripts/UI/UIPanel.cs:314)
PixelCrushers.DialogueSystem.StandardUIMenuPanel.ShowResponsesNow (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIMenuPanel.cs:193)
PixelCrushers.DialogueSystem.StandardUIMenuPanel.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIMenuPanel.cs:177)
PixelCrushers.DialogueSystem.StandardUIResponseMenuControls.ShowResponses (PixelCrushers.DialogueSystem.Subtitle lastSubtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIResponseMenuControls.cs:286)
PixelCrushers.DialogueSystem.AbstractDialogueUI.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Abstract/Dialogue/AbstractDialogueUI.cs:298)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowResponsesImmediate (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:346)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:328)
PixelCrushers.DialogueSystem.ConversationView.StartResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:456)
PixelCrushers.DialogueSystem.ConversationController.OnFinishedSubtitle (System.Object sender, System.EventArgs e) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:282)
PixelCrushers.DialogueSystem.ConversationView.FinishSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:428)
PixelCrushers.DialogueSystem.ConversationView.OnFinishedSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:435)
PixelCrushers.DialogueSystem.Sequencer.FinishSequence () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Sequencer/Sequencer.cs:602)
PixelCrushers.DialogueSystem.Sequencer.Update () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Sequencer/Sequencer.cs:594)

But if I put "Continue@1.5" (I made a shortcut as {{c15}}) for the START node, everything works fine.
If its only "Continue@1.0", same error occurs.

11112222.png (34.12 KiB) Viewed 722 times

[Tony Li]

Hi,

Are you sure you updated to version 2.2.30? (Please check Plugins/Pixel Crushers/Dialogue System/_README.txt.) UIPanel.cs Line 314 should not throw this error:

NullReferenceException: Object reference not set to an instance of an object
PixelCrushers.UIPanel.SetFocus (UnityEngine.GameObject selectable) (at Assets/Plugins/Pixel Crushers/Common/Scripts/UI/UIPanel.cs:314)

[fkkcloud]

Sorry it was 326.

Here it is with 2.2.30.

NullReferenceException: Object reference not set to an instance of an object
PixelCrushers.UIPanel.SetFocus (UnityEngine.GameObject selectable) (at Assets/Plugins/Pixel Crushers/Common/Scripts/UI/UIPanel.cs:326)
PixelCrushers.DialogueSystem.StandardUIMenuPanel.ShowResponsesNow (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIMenuPanel.cs:193)
PixelCrushers.DialogueSystem.StandardUIMenuPanel.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIMenuPanel.cs:177)
PixelCrushers.DialogueSystem.StandardUIResponseMenuControls.ShowResponses (PixelCrushers.DialogueSystem.Subtitle lastSubtitle, PixelCrushers.DialogueSystem.Response[] responses, UnityEngine.Transform target) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardUIResponseMenuControls.cs:286)
PixelCrushers.DialogueSystem.AbstractDialogueUI.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Abstract/Dialogue/AbstractDialogueUI.cs:298)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowResponsesImmediate (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:346)
PixelCrushers.DialogueSystem.StandardDialogueUI.ShowResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses, System.Single timeout) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/UI/Standard/Dialogue/StandardDialogueUI.cs:328)
PixelCrushers.DialogueSystem.ConversationView.StartResponses (PixelCrushers.DialogueSystem.Subtitle subtitle, PixelCrushers.DialogueSystem.Response[] responses) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:456)
PixelCrushers.DialogueSystem.ConversationController.OnFinishedSubtitle (System.Object sender, System.EventArgs e) (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Controller/ConversationController.cs:282)
PixelCrushers.DialogueSystem.ConversationView.FinishSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:428)
PixelCrushers.DialogueSystem.ConversationView.OnFinishedSubtitle () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/View/View/ConversationView.cs:435)
PixelCrushers.DialogueSystem.Sequencer.FinishSequence () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Sequencer/Sequencer.cs:602)
PixelCrushers.DialogueSystem.Sequencer.Update () (at Assets/Plugins/Pixel Crushers/Dialogue System/Scripts/MVC/Sequencer/Sequencer.cs:594)

[Tony Li]

Line 326 is:

Code: Select all

UnityEngine.EventSystems.EventSystem.current.SetSelectedGameObject(null);

Does your scene have an EventSystem?

[fkkcloud]

I am using Rewired.

It works if I put 1.5 second delay ("Continue@1.5;") on the START node somehow (If I put 1.0 second delay aka "Continue@1.0;", it crashes).

화면 캡처 2022-09-06 142702.png (121.73 KiB) Viewed 719 times

But RewiredEventSystem is child class of EventSystem

[Tony Li]

Is the Rewired Event System present when the scene starts? Or only after 1.5 seconds?

[fkkcloud]

It is always present because its part of GameManager which is DontDestroyOnLoad since beginning of the application.

[Tony Li]

Would you please confirm in your project that line 326 of Assets/Plugins/Pixel Crushers/Common/Scripts/UI/UIPanel.cs is actually this:

Code: Select all

UnityEngine.EventSystems.EventSystem.current.SetSelectedGameObject(null);