Dialogue subtitle panel and dialogue panel not going away at end of conversation

Announcements, support questions, and discussion for the Dialogue System.
Post Reply
hipsterdufus
Posts: 95
Joined: Thu Aug 12, 2021 6:39 pm

Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by hipsterdufus »

Hi Tony, sorry to bother you again. I am having an issue in my game which has 2 subtitles and 2 response menus where the subtitle and main panel do not go away. When I go into the game, I can trigger a conversation and everything works fine, but if I start a subsequent conversation that uses the other subtitle, it fails to close. In the scene hierarchy I see that both subtitles are now active for some reason (the first time around only one subtitle and menu will be active and everything works fine). When I did some debugging I can see that it's waiting for one of the panelStates to finish "closing", so that it can call the CloseNow method. I had a similar issue before and it was related to the visibility setting of one of the subtitles. I tried playing around with those but it doesn't seem to make a difference anymore. Any tips on what to look out for?
hipsterdufus
Posts: 95
Joined: Thu Aug 12, 2021 6:39 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by hipsterdufus »

Hmm, I unticked waitForClose on the Standard Dialogue UI and it works now. Although I'm not sure the repercussions of that. It seems like it should work with that ticked on. Still both subtitles are enabled in the scene hierarchy but I guess only one is visible so it's fine.
User avatar
Tony Li
Posts: 21986
Joined: Thu Jul 18, 2013 1:27 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by Tony Li »

Hi,

Are you running two conversations at the same time? Or are you starting the second conversation after the first has fully finished?

If you're running two simultaneous conversations, they must use separate dialogue UIs.

If you're starting the second one after the first has finished, what version of the Dialogue System are you using? Version 2.2.18 has an improvement over 2.2.17 that handles starting a second conversation while the first conversation is still closing the dialogue UI.
hipsterdufus
Posts: 95
Joined: Thu Aug 12, 2021 6:39 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by hipsterdufus »

I am running only one conversation at a time. Using 2.2.18. One dialogue panel with 2 subtitles. I just switch between them depending on who the player talks to. I think it just get's stuck in the closing state somehow. But unticking the waitForClose option works so I guess it's fine. Hopefully I never need that option =)
hipsterdufus
Posts: 95
Joined: Thu Aug 12, 2021 6:39 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by hipsterdufus »

I just upgraded to 2.2.19 and it works fine with the waitForClose option on. Also I'm not sure but it seems to open and close the dialogue more slowly. Maybe that's just my imagination though.
User avatar
Tony Li
Posts: 21986
Joined: Thu Jul 18, 2013 1:27 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by Tony Li »

Did you perhaps modify whatever animator controller the dialogue UI uses? Maybe you had increased the speeds of the animator states, and the update to 2.2.19 pulled in the original version of the animator controller.
hipsterdufus
Posts: 95
Joined: Thu Aug 12, 2021 6:39 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by hipsterdufus »

Yes I think the animation was changed after the update. I used to have a transform animation along with the canvas group fade but after updating it went back to the default canvas group fade I believe.
User avatar
Tony Li
Posts: 21986
Joined: Thu Jul 18, 2013 1:27 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by Tony Li »

Got it. If you re-edit it, I recommend duplicating it, editing the copy, and assigning the copy to your dialogue UI. That way it won't get overwritten if you update the Dialogue System.
fatihyilmazz
Posts: 1
Joined: Thu Sep 16, 2021 2:16 am

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by fatihyilmazz »

Hey there, same issue here.
After updating the asset to version 2.2.20, subtitle panel doesnt close.
Start & Stop conversation events get triggered (camera zoom in out etc works)
User avatar
Tony Li
Posts: 21986
Joined: Thu Jul 18, 2013 1:27 pm

Re: Dialogue subtitle panel and dialogue panel not going away at end of conversation

Post by Tony Li »

fatihyilmazz wrote: Thu Sep 16, 2021 2:27 amHey there, same issue here.
After updating the asset to version 2.2.20, subtitle panel doesnt close.
Start & Stop conversation events get triggered (camera zoom in out etc works)
We'll need to look at this on a case-by-case basis since, generally speaking, nothing changed that would universally stop subtitle panels from closing.

If you customized one of the Dialogue System's assets, such as an animation clip, make sure your customizations didn't get overwritten by the update.

Check the Visibility settings of the subtitle panels.

If you can't find the issue, feel free to send a reproduction project to tony (at) pixelcrushers.com.
Post Reply