Actor Custom Node Color is lost

[bbjones]

I have seen this happen occasionally since I started using custom node colors.

I have tried to reproduce it consistently but can't.

Some recent steps before it happened this time:
- no changes to dialogue system parts
- Dialogue editor is docked in same tab list as the scene, asset store etc.
- I have other node editors open, Invector FSM, Opsive Behaviour designer
- I have gone back and forth with play mode several times
- Dialogue editor/converstations was the active tab

Editor looks like this:

dialogueSystem_customNodeColorLost.png (13.03 KiB) Viewed 618 times

If I turn off custom node color it is restored to default.

dialogueSystem_customOff.png (15.24 KiB) Viewed 618 times

If I turn on custom node color again, it will not restore the color, it goes back to no-color like the first image.

The only way I've found to restore custom colors is to close the Dialogue editor and open it again.

dialogueSystem_customRestored.png (14.4 KiB) Viewed 618 times

Not a big deal, just a paint to have to close/re-open and dock the editor again.

[Tony Li]

Hi,

What version of the Dialogue System are you using? (Tools > Pixel Crushers > Dialogue System > Welcome Window or _README.txt file)

[bbjones]

dialogue system v2.2.8 with TMP Pro enabled.
unity v2020.1.3f1 (was happening on 1.2f1 as well)

I see v2.2.9 is available so I'll update to that, I'm not freezing any assets versions for about month or so.

[bbjones]

And after finding and reading the 2.2.9 release notes I see this was addressed so I think we can assume this is resolved

Fixed: Issue where custom node colors could become transparent.

[bbjones]

I haven't seen the transparent problem after upgrading to 2.2.9 bu I am getting inconsistent results using colors and when changing colors.

I'm not entirely certain how to reproduce the issues but it seems there are 2:

1) Some colors simply don't work. For example, create a new actor, check the color box and select solid black (RGB 0,0,0). That actor's nodes will remain default grey. Maybe there are some RGB ranges that aren't supported?

2) Changing colors doesn't work. It doesn't look like you can change colors after they are created. You can select a new color and it shows that new color on the Actor tab, but the nodes do not change color. What does work is to uncheck the option, check it again (this reverts back to white) then select your new color.

And in case you were bored and needed something to do...
It would be handy to also allow custom foreground/text color in the nodes to allow a wider range of node coloring.

[Tony Li]

Hi,

1) Solid black (0,0,0) isn't allowed. You could cheat by using (0,0,1). Since you can't set the foreground text color, and the light skin's text is black, you wouldn't be able to see the text if the node color were black. I'll consider adding an option to change the text color.

2) That's just a bad design decision on my part. When you select a conversation in the Conversations section, it caches the actors' node colors. If you go to the Actors section and change a node color, it doesn't refresh the cache. I'll change this. In the meantime, if you change conversations and then change back, it will refresh the cache.